Win98 compatibility

[twex]

Version 2.0.5 calls the unsupported function SHGetFolderPathA (instead of SHGetSpecialFolderPathA).

Or perhaps you dropped support for that OS, then I guess it's not a bug...

[DevUrandom]

The call would then be

Code: Select all

SHGetSpecialFolderPathA( NULL, tmpstr, CSIDL_PERSONAL, TRUE )

instead of

Code: Select all

SHGetFolderPathA( NULL, CSIDL_PERSONAL|CSIDL_FLAG_CREATE, NULL, SHGFP_TYPE_CURRENT, tmpstr )

?

[Kreuvf]

Same problem here; 2.0.5 does not start due to this problem (of course xD).

[DevUrandom]

So who needs Win98 compatibility? I think when I last asked there was no one who needed it. Let's find out how it is currently.

[kage]

So who needs Win98 compatibility? I think when I last asked there was no one who needed it. Let's find out how it is currently.

looks like at least 2 people

[DevUrandom]

Yep. I needed a remainder, so I don't forget to change it for 2.0.6. And actually I don't know how this works one Win98 and I can't test it myself...

[lav_coyote25]

ok here it is :


Official call for BETA TESTERS of the WIN98 code.  contact Devurandom as soon as possible.

[Kreuvf]

*callsdevu* That enough?

[DevUrandom]

Ok then. When I have time, I'll create a snapshot of the 2.0 branch with the other, Win98 compatible, folder thingy.

[lav_coyote25]

*callsdevu* That enough?

yes thankyou. ;D

[Mr. Pig]

The call would then be

Code: Select all

SHGetSpecialFolderPathA( NULL, tmpstr, CSIDL_PERSONAL, TRUE )

instead of

Code: Select all

SHGetFolderPathA( NULL, CSIDL_PERSONAL|CSIDL_FLAG_CREATE, NULL, SHGFP_TYPE_CURRENT, tmpstr )

?

Can't you just use a #define for the Windows Version number so that it executes the decent function for XP systems and the "bad code" for 98. That way 98 is unsupported but launches? Or are the two functions very different and effect more than just a few lines of code where #defines are not worth it. (I am assuming this is C/C++)

[DevUrandom]

Actually it is only one line of code.
But on WinXP the folder can be a "virtual" one, which means that the user can choose another folder to be his My Documents folder. On Win98 it is a specific path. At least that's how I understood it in the MSDN...
MS provides some hooks to find out the shell32 version at runtime. I'll use that to check which function to use. (But currently have no time. But it is on the roadmap for 2.0.6.)

[Kreuvf]

Ok then. When I have time, I'll create a snapshot of the 2.0 branch with the other, Win98 compatible, folder thingy.

Just for clarification: How much disk space is neccessary in order to do win98-compatibility-beta-testing?

[DevUrandom]

About 2MB... You only need a different exe. (So you can look yourself how big that is. The Win98 fallback code wont add many bytes to it. )

PS: Do you have IE5 installed?

Because the MSDN library says about SHGetFolderPath:

Minimum operating systems
Windows 95 with Internet Explorer 5.0, Windows 98 with Internet Explorer 5.0, Windows 98 Second Edition (SE), Windows NT 4.0 with Internet Explorer 5.0, Windows NT 4.0 with Service Pack 4 (SP4)

MSDN library

So actually even Win95 should be supported, as long as IE5 is installed...

[Kreuvf]

MSIE6 installed.