Zarel wrote:Erm. That's usually how it goes. You post a patch in a ticket, and wait for feedback. After a few days with no negative feedback, you commit the patch. If there are problems, you fix them. How else would you suggest it be done?
Most projects do the commits in the unstable branch, then after a few weeks of testing, it then is ported over to stable if deemed worthy.
Vexxy's revert was temporary. He said "reverting so I can work on stuff", not "reverting because this patch should be tested more thoroughly before it can be committed again", so as far as I know it was safe to commit my fixed version.

you got some odd nick names for your teammates.
I did basic testing with several different maps, but I didn't test Rush, so I didn't notice its problem in skirmish. More in-depth testing is usually done in-branch, where we found the first bug and fixed it, and are in the process of fixing the second bug, which would go a lot smoother if you actually tried to help instead of just yelling "it's broken and it's all your fault". I mean, at least tell me what's wrong with it.
It wasn't just rush, it was also urban, and a few others as well.
The problem is obvious with just some normal testing, start a multiplayer game, then host, and you can't. It can't find any maps now.
I've never really thought of "commit to trunk first" as a necessary intermediate step. I've nearly always committed to both branches simultaneously. I mean, it's not like we're releasing 2.3-branch as 2.3.2 immediately.
All patches should get testing done in a unstable branch, otherwise you run into these issues every time.
As for wanting to help fix the bugs, I don't believe you were treated as an idiot there. We weren't sure if your patch was the right solution, so we discussed it first. Happens to everyone. My second patch didn't get accepted immediately, either. Per voiced a bunch of concerns. And then, funny thing, I fixed the problems Per talked about, instead of whining about how I was being oppressed or something.
Of course
you would say that. I don't expect you to notice how incredibly rude you treat others, since you appear to have different rules for different people.
