unable to compile latest SVN

[zspace]

I just downloaded the latest version from the svn (version number 7234) to try and compile it and for some reason I can't get it to compile. I have done this on several occasions and I know how, but I keep getting an error when I run the "make" command. I included the ./configure and make outputs below. I hope that someone can tell we what's doing this or fix the problem. I doubt the OS matters but it's Ubuntu 9.04 x64

./configure

Code: Select all

checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for gcc option to accept ISO C99... -std=gnu99
checking for gcc -std=gnu99 option to accept ISO Standard C... (cached) -std=gnu99
checking for ranlib... ranlib
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for bison... bison -y
checking for bison >= 1.31... found 2.3, ok
checking for flex... flex
checking lex output file root... lex.yy
checking lex library... -lfl
checking whether yytext is a pointer... yes
checking for flex >= 2.5.33... found 2.5.35, ok
checking for flex != 2.5.34... not found, good
checking whether perl executable path has been provided... no
checking for perl... /usr/bin/perl
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for perl version... 5.10.0
checking for gawk... (cached) mawk
checking how to run the C preprocessor... gcc -std=gnu99 -E
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for strlcpy... no
checking for strlcat... no
checking whether NLS is requested... yes
checking for msgfmt... /usr/bin/msgfmt
checking for gmsgfmt... /usr/bin/msgfmt
checking for xgettext... /usr/bin/xgettext
checking for msgmerge... /usr/bin/msgmerge
checking for ld used by GCC... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for shared library run path origin... done
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... yes
checking whether to use NLS... yes
checking where the gettext function comes from... libc
checking for msgfmt >= 0.15... found 0.17, ok
checking for xgettext >= 0.15... found 0.17, ok
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for pkg-config >= 0.9... found 0.22, ok
checking whether to build NSIS installer... no
checking whether to compile in debug mode... yes
checking for SDL... yes
checking for PNG... yes
checking for THEORA... yes
checking for OPENAL... yes
checking for OGGVORBIS... yes
checking for SQLITE... yes
checking popt.h usability... yes
checking popt.h presence... yes
checking for popt.h... yes
checking for poptGetContext in -lpopt... yes
checking physfs.h usability... yes
checking physfs.h presence... yes
checking for physfs.h... yes
checking for PHYSFS_init in -lphysfs... yes
checking SDL/SDL_net.h usability... yes
checking SDL/SDL_net.h presence... yes
checking for SDL/SDL_net.h... yes
checking for SDLNet_Init in -lSDL_net... yes
checking SDL/SDL_opengl.h usability... yes
checking SDL/SDL_opengl.h presence... yes
checking for SDL/SDL_opengl.h... yes
checking for main in -lGL... yes
checking for main in -lGLU... yes
checking GL/glc.h usability... yes
checking GL/glc.h presence... yes
checking for GL/glc.h... yes
checking for main in -lGLC... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating po/Makefile.in
config.status: creating doc/Makefile
config.status: creating build_tools/Makefile
config.status: creating build_tools/autorevision/Makefile
config.status: creating icons/Makefile
config.status: creating data/Makefile
config.status: creating data/base/Makefile
config.status: creating data/base/stats-sql/Makefile
config.status: creating data/mods/Makefile
config.status: creating data/mods/global/Makefile
config.status: creating data/mods/multiplay/Makefile
config.status: creating data/music/Makefile
config.status: creating pkg/Makefile
config.status: creating pkg/nsis/Makefile
config.status: creating win32/Makefile
config.status: creating tests/Makefile
config.status: creating lib/Makefile
config.status: creating lib/framework/Makefile
config.status: creating lib/exceptionhandler/Makefile
config.status: creating lib/gamelib/Makefile
config.status: creating lib/ivis_opengl/Makefile
config.status: creating lib/ivis_common/Makefile
config.status: creating lib/netplay/Makefile
config.status: creating lib/script/Makefile
config.status: creating lib/sequence/Makefile
config.status: creating lib/sound/Makefile
config.status: creating lib/sqlite3/Makefile
config.status: creating lib/widget/Makefile
config.status: creating src/Makefile
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing po-directories commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
configure: 
configure: *** Running in debug mode! ***
configure: 
configure: WARNING: Distributor unknown!
configure: Use --with-distributor when compiling package for distribution

make:

Code: Select all

make  all-recursive
make[1]: Entering directory `/home/kyle/warzone'
Making all in build_tools
make[2]: Entering directory `/home/kyle/warzone/build_tools'
Making all in autorevision
make[3]: Entering directory `/home/kyle/warzone/build_tools/autorevision'
./autorevision +cstr -v ../.. ../../src/autorevision.h
Revision unchanged (7234). Skipping.
old = "7234"; new = "7234"
make[3]: Leaving directory `/home/kyle/warzone/build_tools/autorevision'
make[3]: Entering directory `/home/kyle/warzone/build_tools'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/home/kyle/warzone/build_tools'
make[2]: Leaving directory `/home/kyle/warzone/build_tools'
Making all in win32
make[2]: Entering directory `/home/kyle/warzone/win32'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/home/kyle/warzone/win32'
Making all in lib
make[2]: Entering directory `/home/kyle/warzone/lib'
Making all in framework
make[3]: Entering directory `/home/kyle/warzone/lib/framework'
make  all-am
make[4]: Entering directory `/home/kyle/warzone/lib/framework'
make[4]: Nothing to be done for `all-am'.
make[4]: Leaving directory `/home/kyle/warzone/lib/framework'
make[3]: Leaving directory `/home/kyle/warzone/lib/framework'
Making all in exceptionhandler
make[3]: Entering directory `/home/kyle/warzone/lib/exceptionhandler'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/exceptionhandler'
Making all in script
make[3]: Entering directory `/home/kyle/warzone/lib/script'
make  all-am
make[4]: Entering directory `/home/kyle/warzone/lib/script'
make[4]: Nothing to be done for `all-am'.
make[4]: Leaving directory `/home/kyle/warzone/lib/script'
make[3]: Leaving directory `/home/kyle/warzone/lib/script'
Making all in sequence
make[3]: Entering directory `/home/kyle/warzone/lib/sequence'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/sequence'
Making all in ivis_common
make[3]: Entering directory `/home/kyle/warzone/lib/ivis_common'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/ivis_common'
Making all in ivis_opengl
make[3]: Entering directory `/home/kyle/warzone/lib/ivis_opengl'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/ivis_opengl'
Making all in gamelib
make[3]: Entering directory `/home/kyle/warzone/lib/gamelib'
make  all-am
make[4]: Entering directory `/home/kyle/warzone/lib/gamelib'
make[4]: Nothing to be done for `all-am'.
make[4]: Leaving directory `/home/kyle/warzone/lib/gamelib'
make[3]: Leaving directory `/home/kyle/warzone/lib/gamelib'
Making all in sound
make[3]: Entering directory `/home/kyle/warzone/lib/sound'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/sound'
Making all in sqlite3
make[3]: Entering directory `/home/kyle/warzone/lib/sqlite3'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/sqlite3'
Making all in netplay
make[3]: Entering directory `/home/kyle/warzone/lib/netplay'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/netplay'
Making all in widget
make[3]: Entering directory `/home/kyle/warzone/lib/widget'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/kyle/warzone/lib/widget'
make[3]: Entering directory `/home/kyle/warzone/lib'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/home/kyle/warzone/lib'
make[2]: Leaving directory `/home/kyle/warzone/lib'
Making all in src
make[2]: Entering directory `/home/kyle/warzone/src'
make  all-am
make[3]: Entering directory `/home/kyle/warzone/src'
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -DYY_NO_INPUT -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/SDL     -I/usr/include/libpng12         -DDEBUG -DDATADIR="\"/usr/local/share/warzone2100\"" -DLOCALEDIR="\"/usr/local/share/locale\"" -I..  -O0 -g -Wall -Werror -Wno-unused-label -Wno-pointer-to-int-cast -Wmissing-field-initializers -Wcast-align -Wwrite-strings -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wno-format-security  -MT structure.o -MD -MP -MF .deps/structure.Tpo -c -o structure.o structure.c
cc1: warnings being treated as errors
structure.c: In function ‘aiUpdateStructure’:
structure.c:3155: error: suggest parentheses around && within ||
make[3]: *** [structure.o] Error 1
make[3]: Leaving directory `/home/kyle/warzone/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/kyle/warzone/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/kyle/warzone'
make: *** [all] Error 2

[zspace]

I think I may have found it. I don't know c++, but I think I fixed it. I really can't say if this is what you wanted as far as the logic goes, but it does compile now.

Original /src/structure.c line:3155-57:

Code: Select all

if (psDroid->action == DACTION_WAITFORREPAIR ||
				    psDroid->action == DACTION_WAITDURINGREPAIR
				    && xdiff*xdiff + ydiff*ydiff > (TILE_UNITS*5/2)*(TILE_UNITS*5/2))

Fixed /src/structure.c line:3155-57:

Code: Select all

if (psDroid->action == DACTION_WAITFORREPAIR ||
				   (psDroid->action == DACTION_WAITDURINGREPAIR
				    && xdiff*xdiff + ydiff*ydiff > (TILE_UNITS*5/2)*(TILE_UNITS*5/2)))

[Zarel]

Okay, I've fixed it in r2135.

Which compiler are you using? It seems weird that it would count a "suggestion" as an error, and refuse to compile. The code is perfectly valid with or without the parentheses.

[stiv]

-Werror

Not weird, at all. That is what the -Werror flag does - turns warnings into errors.

[jaakan]

Not weird, at all. That is what the -Werror flag does - turns warnings into errors.

U9.04 has gcc 4.3.3 and it's stricter coding style wise than older versions.

[cybersphinx]

Not weird, at all. That is what the -Werror flag does - turns warnings into errors.

And it can be disabled via ./configure --enable-debug=relaxed.

[zspace]

ya you guys where right
I downloaded the newest one and it works fine now.
I am using gcc 4.3.3, like jaacan said.