Python LobbyServer Rewrite

[gschaden]

Hi, after a litte discussion on irc I checked out the svn source, and had a look at the lobbyserver.

I rewrote some sections of the code.
* use logging lib for different logging level
* use classes for Game, GameDB
* exception handling, which handles network errors
* StatusPrinter Thread (shows current games every second on the console)

I did some tests with two warzone instances running.

Are there future plans for the server?
* webgui
* telnet interface
* killing games

[gschaden]

Here is an updated version

* commandline support
Commands: help, list, kill, info, quit

* decoding to gamestructure

[Buginator]

Are there future plans for the server?
* webgui
* telnet interface
* killing games

First off, nice job!
I am not too sure how frequent the devs look in the forums, so it may be better to submit this either to the patch tracker at https://gna.org/patch/?group=warzone
or the mailing list at https://gna.org/mail/?group=warzone

A webgui would be nice, as would the other things you have listed.
I was thinking maybe implement one of the IRC bots  in #warzone to issue commands to it, like !game would PM people the current game list  (since we lack a real lobby system)  and then some OP commands like !killgame ID or !resetserver to handle server quirks.  But a webgui might be the way to go.

We are also in need of a lobby system that can be run on all the platforms that we support.
The current GUI code in warzone is less than stellar for handling a true lobby system that most people are familiar with, as you can probably tell.

[DevUrandom]

Voice of the devs:
The initial code you provided was not yet commited, because it was found that it adds much complexity for little gain. Most of us are not really Python pros...

Personal voice:
If you add features like the ones you just posted, try to keep the complexity still low and comment good (they seem to be lacking completely currently...), I see a bright future.

[gschaden]

Hi,


I mean the current code is not fault tollerant and complex and it does not work well. We know that because we sometimes get ghost games. Python is a very high level language, and i dont think it would be better to produce more code than necessary.

If there is not that much python know-how, why do you use a python server, and not the c++ version.

And what do you expect me to do now?

[gschaden]

I also had a look at the last commit, it is just a work arround for a problem which only exists, ebecause there is no correct error handling.

And please dont tell me that this patch makes the code easier or more robust. Documentation is rare, and the most important thing the code introduces an other problem. Each ghost game still consumes resources at the server, so you have to restart it from time to time, to free it. 

If you want I can take care of this code, and make it as robust as possible.

[DevUrandom]

Heyhey... No personal attack or anything...

On the comments I made: I just repeated what appeared to be common consensus on IRC...
On the rest: If you can spice it up with some comments, I'd be fine already. Since currently I find it rather hard to figure out what goes on and why...
And whether the last commit to it was a hack or not... I don't know, I didn't care that deeply about this server and neither am I a wizard with Python. I am trying to improve though.
Against the C++ one was that it uses Boost, which was to bothersome for the admin to install, iirc.

I'll have a look at your new code with comments, and if I can understand it and it works (which I do not expect otherwise), I'll set it up on the server for some public testing, as Fred suggested.
(Post that on the tracker, please, which makes it easier for us to ... track it.)

//edit:grammar...

[EvilGuru]

I quite liked the new version. Although saying that I do have quite a good grounding in Python. The replacement, although possibly a little more complex is more extensible than the current one.

On a side note if you think the Python one is complex take a look at the C++ one. Took me a good 10-15 minutes to get my head around it.

Only possible improvement to the updated Python one is using the 'with' clause added in Python 2.5. That should get rid of the @ decorators.

Regards, Freddie.

[Buginator]

I tried out the newest version last night locally, worked well from what I could tell.

Thanks for the update of the code!

[DevUrandom]

I've commited file #3421 and file #3422 in r3139.

[Buginator]

How hard would it be to keep track of daily stats ?

Something along the lines of # of games played today, # of connection attempts (visitors checking lobby), and things of that nature?

I know Kamaze is trying hard to get python 2.5 installed so we can use your work, but right now, I use it locally, and it is pretty nice!

[Terminator]

I think there stats is can be : # hosted games for last hour, # of visitors. Current host cannt support more features. If will be more..like users registrations, their ranks, played games.....so than will be more statistics..

[Kamaze]

I know Kamaze is trying hard to get python 2.5 installed so we can use your work, but right now, I use it locally, and it is pretty nice!

This server will receive a re-setup very soon since some things are broken, including apt-get...