Coding Feedback
Posted: 25 Jun 2011, 00:45
Hello Everyone
I decided to create this thread because of one reason... i was seeing the codebut i dont know where to start so i decided to give a feedback about the code:
Comments:
the code is pretty well commented, and i dont think i need to give comments about it
Code:
the name of the functions are self explanatory on goodpoint on that, however, mixing c with c++, then mix with qt c++ is sort of mixing salt, sugar and pepper together on food
, i would like to see it modified slowly and calmly, that way we could go longer
Organization:
ill be direct and honest.................................it sucks
, heck its like you throw organiztion out of the window
i mean, this is the first time i see an cpp file with more than 4000 lines
(display3d.cpp), and not only that, if you change anything with it even a line, the entire file will be compiled, wasting time.
i would like it to be organized in foldes
for example
folder "AI" where there lies the AI player scripts and code
folder "ui" where lies the 2D part of the game which is basically the ui
folder "scene" where lies the 3D part of the game which is of course the game scene (terrain, etc)
folder "math3d" where lies the 3D math for the scene (raycasting, cameras, etc)
folder "main" where lies the initial actions of the program
folder "gui" where lies the code that initializes the GUI, it may be the QGLWidget code or what it is
folder "structures" where lies the code of the buildings and stuff
folder "units" where lies the code of the units
folder "scripts" where lies other kind of scripts
and finally the folder "etc" where lies the less important part of the game coding (version,etc)
because the way it is now it just scares me away, well i dont even know where is the part that renders the scene, im sorry, im better off making my own projects that i do on my free time than trying to understand the entire code
my two cents
I decided to create this thread because of one reason... i was seeing the codebut i dont know where to start so i decided to give a feedback about the code:
Comments:
the code is pretty well commented, and i dont think i need to give comments about it
Code:
the name of the functions are self explanatory on goodpoint on that, however, mixing c with c++, then mix with qt c++ is sort of mixing salt, sugar and pepper together on food
Organization:
ill be direct and honest.................................it sucks
i mean, this is the first time i see an cpp file with more than 4000 lines
i would like it to be organized in foldes
for example
because the way it is now it just scares me away, well i dont even know where is the part that renders the scene, im sorry, im better off making my own projects that i do on my free time than trying to understand the entire code
my two cents