Idea for patch, feedback wanted: Fade when starting game

Discuss the future of Warzone 2100 with us.
Post Reply
aliswe
Trained
Trained
Posts: 56
Joined: 01 Apr 2020, 22:11

Idea for patch, feedback wanted: Fade when starting game

Post by aliswe » 01 Apr 2020, 22:37

Hello,

I am requesting some preliminary feedback on a change I wish to introduce (code not written yet). It's to do with the first second of starting a game, for example the Alpha campaign.

First off, the main menu screen should really take half a second or so to fade TO BLACK.

Secondly, the game should take its first half second or so to fade FROM BLACK.

Why I split those two is because I believe coding will be needed in two different parts of the project.

Thirdly, I want to look into the "zooming" or "landing" of the camera on game start. It's looking OK but upon closer inspection it's acting really strange.

Sometimes, it goes from up to down, like landing an aircraft. Sometimes, it goes from down to up, like the ascension of a helicopter. When starting the alpha campaign, on first run, the effect executes successfully. If I "Quit game", and run the same Alpha campaign again, the effect is barely noticeable (maybe 1/10th of a second with only about 10 pixels movement). The subsequent times, there is no "zooming" effect at all.

I'd like to check that code and perhaps adjust the logic to being consistent every time, and perhaps tweak it just a little bit, it doesn't feel 100% natural as it is currently.

Reason I'm asking about feedback is because I don't want to work on something that in the end will not be accepted because it's not prioritized or w/e.

BTW: Hi, I'm Bjorn Ali from Sweden. I really care (and get hung up!) about first impressions. I'm actually not new here, I made a patch about 10 years ago, also on a small detail with regards to smoother arc rotating (with the right mouse button).

Take care,
Bjorn Ali

User avatar
Berserk Cyborg
Code contributor
Code contributor
Posts: 874
Joined: 26 Sep 2016, 19:56

Re: Idea for patch, feedback wanted: Fade when starting game

Post by Berserk Cyborg » 03 Apr 2020, 02:44

We will pretty much take any feature/improvement patch provided it works and has been tested.

pastdue
Warzone 2100 Team Member
Warzone 2100 Team Member
Posts: 260
Joined: 13 Aug 2017, 17:44

Re: Idea for patch, feedback wanted: Fade when starting game

Post by pastdue » 03 Apr 2020, 04:29

As a quick note: fading the main screen likely touches code that has been refactored as part of:
https://github.com/Warzone2100/warzone2100/pull/489

So it would probably be best to base your work off of that PR (which will be merged as part of 3.4.0), to avoid having to re-do it.

aliswe
Trained
Trained
Posts: 56
Joined: 01 Apr 2020, 22:11

Re: Idea for patch, feedback wanted: Fade when starting game

Post by aliswe » 03 Apr 2020, 07:39

Sounds good!

aliswe
Trained
Trained
Posts: 56
Joined: 01 Apr 2020, 22:11

Re: Idea for patch, feedback wanted: Fade when starting game

Post by aliswe » 03 Apr 2020, 20:25

On second thought, this branch compiles but doesn't run for me - in WSL (not very surprising!) - and I am currently stuck on the Windows regular build bco PhysFS. Feel free to assist me on that issue ...

So I've decided to wait a bit with this suggestion, and try to improve upon the zooming logic (based on the master branch) as long as the Vulkan branch is unmerged. When it is, I'll have no choice but to troubleshoot the Vulkan stuff in WSL.

Thanks a lot guys!

Post Reply