Bugs in current SVN

[iamtheari]

I have spotted two so far, at least that come up on my system:

1. configure.ac called for AC_CONFIG_HEADER but automake requires the use of AM_CONFIG_HEADER instead
2. The same script bug I pointed out a while back.  Easily fixed by a check for whether psFunc->type >= VAL_USERTYPESTART before getting the offset into an array of psFunc->type - VAL_USERTYPESTART (meaning that a lower number in psFunc->type would result in reading garbage from before the array in memory)

I have fixed both of these and am ready to commit them unless there is an objection.  I also have a change implemented which reports a file and line number for script parse errors rather than just a line number (which doesn't even refer to a file but to the total number of lines parsed by the game so far).  This is immensely useful to have.

Any objection to me committing all of this?  The game appears to work fine with these three things fixed/changed.

[iamtheari]

I should add that the file/line reporting code requires the use of the function GetLastResourceFilename() from lib/script/ code.  I don't know if this is considered a major no-no or not.

[Per]

Sounds good to me.

[DevUrandom]

Forward from the mailinglist:

Am Sonntag, 20. August 2006 21:44 schrieb Dennis Schridde:
> Am Sonntag, 20. August 2006 13:16 schrieb Ari Johnson:
> > Author: ari
> > Date: Sun Aug 20 13:16:40 2006
> > New Revision: 234
> >
> > URL: http://svn.gna.org/viewcvs/warzone?rev=234&view=rev
> > Log:
> > AM_CONFIG_HEADER replaces AC_CONFIG_HEADER to avoid complaints from
> > automake
>
> Why? I just changed it the other way round because we required automake 1.8
> and in the automake docs it is written that AM_CONFIG_HEADER is deprecated.
I checked it again using automake 1.8.5.
automake 1.8.5 understands AC_CONFIG_HEADER

When I tested with 1.6.3 it bailed, saying:
configure.ac:8: `automake requires `AM_CONFIG_HEADER', not `AC_CONFIG_HEADER'

So it _should_ work with the version of automake we require (1.8).

--Dennis