kinetic/thermal armor dont work?

Discuss the future of Warzone 2100 with us.
Post Reply
User avatar
andrvaut
Trained
Trained
Posts: 98
Joined: 02 Jan 2016, 12:44

kinetic/thermal armor dont work?

Post by andrvaut » 14 Jun 2018, 22:30

In 3.2.3 and last master kinetic/thermal armor do not affect the damage. #4804
Image
Last edited by andrvaut on 15 Jun 2018, 12:13, edited 2 times in total.
vaut ΣΑ [GN], ru streamer.
Tournaments channel: https://www.youtube.com/channel/UCzusNa-54ydodtSz2TdHFww

User avatar
Berserk Cyborg
Code contributor
Code contributor
Posts: 599
Joined: 26 Sep 2016, 19:56

Re: kinetic/thermal armor dont work!!!

Post by Berserk Cyborg » 15 Jun 2018, 03:01

That debug output is misleading for "damage" since it is not the true damage value.

combat.cpp's objDamage() function:

Code: Select all

debug(LOG_ATTACK, "objDamage(%d): body %d armour %d damage: %d", psObj->id, psObj->body, armour, damage);

	if (psObj->type == OBJ_DROID)
	{
		DROID *psDroid = (DROID *)psObj;

		// Retrieve highest, applicable, experience level
		level = getDroidEffectiveLevel(psDroid);
	}

	// Reduce damage taken by EXP_REDUCE_DAMAGE % for each experience level
	int actualDamage = (damage * (100 - EXP_REDUCE_DAMAGE * level)) / 100;

	// Apply at least the minimum damage amount
	actualDamage = MAX(actualDamage - armour, actualDamage * minDamage / 100);

	// And at least MIN_WEAPON_DAMAGE points
	actualDamage = MAX(actualDamage, MIN_WEAPON_DAMAGE);
...
Probably should be moved farther into the function as something like:

Code: Select all

debug(LOG_ATTACK, "objDamage(%d): body %d armour %d damage: %d", psObj->id, psObj->body, armour, actualDamage);
Also, I would not trust the guide to be completely accurate as I don't think it reflects 3.2 or master in some areas.

User avatar
andrvaut
Trained
Trained
Posts: 98
Joined: 02 Jan 2016, 12:44

Re: kinetic/thermal armor dont work!!!

Post by andrvaut » 15 Jun 2018, 08:46

Yes you are right.
Can you change the output to BASIC DAMAGES?
like http://betaguide.wz2100.net/Formulas.html
vaut ΣΑ [GN], ru streamer.
Tournaments channel: https://www.youtube.com/channel/UCzusNa-54ydodtSz2TdHFww

Post Reply