@Per Cant you split threads to editor and stats discussion?
in loadPropulsionStats weight, buildPower, buildPoints does not have default vals but in other it is 0
in weaporn.ini almost all vals has no defaults.
If you has strategy to save files space and hide some options with default vals may be it will be good to add defalt vals to maximum places.
propulsionsounds.ini
if change
(!statsGetAudioIDFromString(list
.toUtf8().constData(), ini.value("szStart").toString().toUtf8().constData(), &startID))
to
...ini.value("szStart", "-1")... some options with default values can be removed
how match in integer:
DEG(1)/3
DEG(3)/4
UWORD_MAX
UBYTE_MAX
In propulsion sounds is only 4 section ("Hover", "Tracked", "Lift", "Wheeled")
in propulsiontypes there are more types "Hover", "Tracked", "Half-Tracked", "Legged", "Lift", "Propellor", "Wheeled", "Ski", "Jump"
May be this files should be joined together?
else if (strcmp(weaponEffect, "ANTI AIRCRAFT") == 0 || strcmp(weaponEffect, "ALL ROUNDER") == 0)
Looks like "ALL ROUNDER" should be renamed to "ANTI AIRCRAFT" in ini files.
In docs said:
minElevation (-90, 0)
maxElevation (0, 90)
is it true?
Code: Select all
if (minElevation > SBYTE_MAX || minElevation < SBYTE_MIN)
{
ASSERT( false,"loadWeaponStats: minElevation is outside of limits for weapon %s",
getStatName(psStats) );
return false;
}
psStats->minElevation = (SBYTE)minElevation;
//set the maxElevation
if (maxElevation > UBYTE_MAX)
{
ASSERT( false,"loadWeaponStats: maxElevation is outside of limits for weapon %s",
getStatName(psStats) );
return false;
}