commit access
Posted: 26 Oct 2017, 09:46
Hello, how i can get access to github repo? I found some bugs in engine and try to fixed, but i don't want to commit any new features, only for bugfixes.
My pullrequest stuck too long sine i think nobody rewiev this.
For example i found new bug in 3.2.2, with mod initialization algorythms:
The wz engine found first 2 mods and send over network that is one mod, for example, we are have mods: "textures.wz", "sounds.wz" and "music.wz", the engine send two mods as "textures.wzsounds.wz" and "music.wz".
I found this strange algorythms in modding.cpp which obviously has a logic error:
Because of that, the game since v3.2.2 is not able to play with mods on multiplayer.
Bug report: http://developer.wz2100.net/ticket/4614
My patch is simple https://github.com/Warzone2100/warzone2100/pull/102 but pullrequest not aprooved sinse 7 Aug.
The secomd bug fix in qtscript, while i working on my bot "BoneCrusher!", i spend many hours while i found that the bug not in my js-code, but in qrscript.cpp, my fix is very simple, only 2 line of code:
More detail in bug report: http://developer.wz2100.net/ticket/4663
https://github.com/Warzone2100/warzone2100/pull/103
Sorry for my english
My pullrequest stuck too long sine i think nobody rewiev this.
For example i found new bug in 3.2.2, with mod initialization algorythms:
The wz engine found first 2 mods and send over network that is one mod, for example, we are have mods: "textures.wz", "sounds.wz" and "music.wz", the engine send two mods as "textures.wzsounds.wz" and "music.wz".
I found this strange algorythms in modding.cpp which obviously has a logic error:
Code: Select all
bool first = true;
for (auto const &s : strs)
{
str += s;
if (!first)
{
str += sep;
}
first = false;
}
return str;
Bug report: http://developer.wz2100.net/ticket/4614
My patch is simple https://github.com/Warzone2100/warzone2100/pull/102 but pullrequest not aprooved sinse 7 Aug.
The secomd bug fix in qtscript, while i working on my bot "BoneCrusher!", i spend many hours while i found that the bug not in my js-code, but in qrscript.cpp, my fix is very simple, only 2 line of code:
More detail in bug report: http://developer.wz2100.net/ticket/4663
https://github.com/Warzone2100/warzone2100/pull/103
Sorry for my english