More research items per page

For code related discussions and questions

More research items per page

Postby smallfly » 04 Apr 2014, 17:24

Maximized the menu height to see much more research/structure items at once. What do you think?

more_research_items_per_page.png


hci.h.png
hci.h.png (28.83 KiB) Viewed 9383 times


hci.h.2.png
hci.h.2.png (24.7 KiB) Viewed 9383 times
Last edited by smallfly on 05 Apr 2014, 19:24, edited 1 time in total.
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page [SOLVED]

Postby themac » 04 Apr 2014, 18:58

Quite good. What about the heavy perspective distortion at high resoulution screen modes? Can it be fixed also? :)
Last edited by themac on 04 Apr 2014, 23:47, edited 1 time in total.
themac
Trained
Trained
 
Posts: 341
Joined: 17 Jul 2009, 19:14
Location: Germany

Re: More research items per page [SOLVED]

Postby themac » 04 Apr 2014, 19:09

You wrote me a private message. I was not able to write back. It told me you have disabled private messages here, so I answer here right now. :)

Das ist bei Warzone etwas kurios. Je höher man die Auflösung einstellt, umso stärker wird die 3D Ansicht verzerrt. In 640 x 480 oder 800 x 600, wie man Warzone früher spielte, sieht alles ganz normal aus. In 1280 x 800 sieht man schon, daß es etwas verzerrt. In 1920 x 1080 oder 2560 x 1600 (Retina Display) wird die perspektivische Verzerrung extrem. Da gehen einem ja die Augen über. Siehe auch meinen inzwischen etwas älteren Beitrag dazu: viewtopic.php?t=11145&p=126602
themac
Trained
Trained
 
Posts: 341
Joined: 17 Jul 2009, 19:14
Location: Germany

Re: More research items per page [SOLVED]

Postby smallfly » 04 Apr 2014, 21:40

Sorry, I cannot help you with the distorsion effect. The 3d distorsion has nothing to do with the user interface overlay. So please stick to topic. If you want to further elaborate on the distorsion, you should do this in the thread you linked yourself.
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page [SOLVED]

Postby smallfly » 04 Apr 2014, 21:48

Now I also maximized the horizontal menu:
maximized_menus.png


Necessary code changes:
hci.h.png
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page [SOLVED]

Postby NoQ » 05 Apr 2014, 06:17

Very nice! Probably worth committing?
User avatar
NoQ
Special
Special
 
Posts: 6136
Joined: 24 Dec 2009, 11:35
Location: /var/zone

Re: More research items per page [SOLVED]

Postby smallfly » 05 Apr 2014, 11:16

NoQ wrote:Very nice! Probably worth committing?

I tried a pull request, but it does not work, because I changed the code in 3.1.1 tag and when I commit to the current master there are lots of commits.
pull_request2.png
pull_request2.png (36.03 KiB) Viewed 9335 times


If I do more changes to the game I will switch to the master version, so that I can contribute to the community. At the moment I just played around a bit with the code.

//edit: But if any dev likes the idea of bigger menus instead of tabbing around the whole time, please feel free to commit the few lines ;-) Here are the changed lines of code. All inside the hci.h file.
Code: Select all
#define SFY_ADD_HEIGHT   (pie_GetVideoBufferHeight() - BASE_COORDS_Y)
...
#define OBJ_BACKX      (RET_X + RET_FORMWIDTH + 100) // BASE_GAP + D_W)   // X coord of object screen back form.
...
#define ESTIMATED_RADAR_WIDTH_DO_NOT_USE 185   
#define OBJ_BACKWIDTH   pie_GetVideoBufferWidth() - 100 - (OBJ_BACKX) - (RET_X) - (ESTIMATED_RADAR_WIDTH_DO_NOT_USE) // 320   //316      // Width of object screen back form.
...
#define OBJ_WIDTH      pie_GetVideoBufferWidth() - 100 - (OBJ_BACKX) - (RET_X) - (ESTIMATED_RADAR_WIDTH_DO_NOT_USE) - 4 // 316   //312//310   // Width of object screen tab form.
...
#define STAT_Y            (45 + E_H - SFY_ADD_HEIGHT)
...
#define STAT_HEIGHT         273 + SFY_ADD_HEIGHT // Height of the tab form.


//edit: i clone the master, edited the hci.h file and tried to commit, but it says:
failed.png
failed.png (42.7 KiB) Viewed 9330 times
Last edited by smallfly on 05 Apr 2014, 19:30, edited 1 time in total.
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page [SOLVED]

Postby smallfly » 05 Apr 2014, 15:51

The right part of the unit editor seems to be invisible (more probably: positioned outside the screen) when applying the patch. So I need to do some research on that, before finally comitting the patch.
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page

Postby smallfly » 05 Apr 2014, 19:30

While the maximized menus look fine...
maximized_menus.png


... there is a problem with the position with the design menu.
design_menu.png


I had to adjust the position of the design elements (right part of design editor) so that they are visible at all.
Code: Select all
#define   RADTLX      (OBJ_BACKX + OBJ_BACKWIDTH + BASE_GAP + 1) //  +D_W)   // Paul's settings (492+12)
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page

Postby vexed » 06 Apr 2014, 03:30

For what it is worth, we don't like github's pull requests.
Read: http://sourceforge.net/p/warzone2100/ma ... /31934936/

Also, everything still must work @ 640x480, that is the smallest resolution we support.
Master is where new features go.
3.1 is supposed to be for bug fixes only.


If you have any other questions, feel free to ask, someone will eventually get to it. :)
/facepalm ...Grinch stole Warzone🙈🙉🙊 contra principia negantem non est disputandum
Super busy, don't expect a timely reply back.
User avatar
vexed
Inactive
Inactive
 
Posts: 2451
Joined: 27 Jul 2010, 02:07

Re: More research items per page

Postby smallfly » 06 Apr 2014, 17:31

vexed wrote:Also, everything still must work @ 640x480, that is the smallest resolution we support.

... and with my current code changes 640x480 and 800x600 wouldnt be supported:
640x480.png
640x480.png (128.09 KiB) Viewed 9267 times

800x600.png
800x600.png (233.13 KiB) Viewed 9267 times


Thus I cannot send any commits at the moment.
smallfly
Trained
Trained
 
Posts: 85
Joined: 21 Aug 2009, 10:26

Re: More research items per page

Postby AWarZoner » 12 Jun 2014, 14:50

smallfly wrote:... and with my current code changes 640x480 and 800x600 wouldnt be supported:
Image


I can't program C++. But will it work if you add a minimum width?

- Andrie
AWarZoner
Trained
Trained
 
Posts: 129
Joined: 21 May 2013, 17:03

Re: More research items per page

Postby demolicious » 17 Jul 2014, 05:41

I think this is an awesome change.
Does anyone even use 640x480 and 800x600 anyway?
demolicious
New user
 
Posts: 1
Joined: 02 Jul 2014, 07:41

Re: More research items per page

Postby Ezio » 01 Oct 2014, 17:31

I don't see these in latest trunk master, what's wrong?
Last edited by Ezio on 01 Oct 2014, 22:37, edited 1 time in total.
Image
Please Read FAQ, Dev Wiki and Search forum for same post before posting
User avatar
Ezio
Trained
Trained
 
Posts: 305
Joined: 24 Apr 2010, 16:42

Re: More research items per page

Postby Iluvalar » 01 Oct 2014, 19:15

demolicious wrote:I think this is an awesome change.
Does anyone even use 640x480 and 800x600 anyway?

I do, get more fps that way on older computer. And really the game textures are not so great you see a big difference. I also enjoy those big buttons, i actually see more clearly the weapon on my design and structure in 800x600 then in 1024x768.
Heretic 2.3 improver and proud of it.
User avatar
Iluvalar
Regular
Regular
 
Posts: 1782
Joined: 02 Oct 2010, 18:44

Next

Return to Coding