Win98 compatibility

Bugs that have been fixed for or in a later version

Do you want Warzone to be Windows 98 compatible?

Yes
3
23%
No
3
23%
Doesn't matter to me
7
54%
 
Total votes: 13

twex
New user
Posts: 1
Joined: 27 Dec 2006, 14:49

Win98 compatibility

Post by twex » 27 Dec 2006, 14:59

Version 2.0.5 calls the unsupported function SHGetFolderPathA (instead of SHGetSpecialFolderPathA).

Or perhaps you dropped support for that OS, then I guess it's not a bug...

User avatar
DevUrandom
Regular
Regular
Posts: 1690
Joined: 31 Jul 2006, 23:14

Re: Win98 compatibility

Post by DevUrandom » 27 Dec 2006, 16:37

The call would then be

Code: Select all

SHGetSpecialFolderPathA( NULL, tmpstr, CSIDL_PERSONAL, TRUE )
instead of

Code: Select all

SHGetFolderPathA( NULL, CSIDL_PERSONAL|CSIDL_FLAG_CREATE, NULL, SHGFP_TYPE_CURRENT, tmpstr )
?

User avatar
Kreuvf
Global Moderator
Global Moderator
Posts: 244
Joined: 22 Sep 2006, 20:56
Contact:

Re: Win98 compatibility

Post by Kreuvf » 05 Jan 2007, 16:28

Same problem here; 2.0.5 does not start due to this problem (of course xD).
Contact only via [url=https://warzone2100.de/impressum.php]e-mail[/url]. GPG encryption supported ([url=https://gpg.kreuvf.de/kreuvf2015.asc]my key[/url]).

User avatar
DevUrandom
Regular
Regular
Posts: 1690
Joined: 31 Jul 2006, 23:14

Re: Win98 compatibility

Post by DevUrandom » 06 Jan 2007, 13:25

So who needs Win98 compatibility? I think when I last asked there was no one who needed it. Let's find out how it is currently.

User avatar
kage
Regular
Regular
Posts: 751
Joined: 05 Dec 2006, 21:45

Re: Win98 compatibility

Post by kage » 07 Jan 2007, 02:17

DevUrandom wrote: So who needs Win98 compatibility? I think when I last asked there was no one who needed it. Let's find out how it is currently.
looks like at least 2 people

User avatar
DevUrandom
Regular
Regular
Posts: 1690
Joined: 31 Jul 2006, 23:14

Re: Win98 compatibility

Post by DevUrandom » 07 Jan 2007, 04:35

Yep. I needed a remainder, so I don't forget to change it for 2.0.6. And actually I don't know how this works one Win98 and I can't test it myself...

User avatar
lav_coyote25
Professional
Professional
Posts: 3434
Joined: 08 Aug 2006, 23:18

Re: Win98 compatibility

Post by lav_coyote25 » 07 Jan 2007, 04:53

ok here it is :


Official call for BETA TESTERS of the WIN98 code.  contact Devurandom as soon as possible.
‎"to prepare for disaster is to invite it, to not prepare for disaster is a fools choice" -me (kim-lav_coyote25-metcalfe) - it used to be attributed to unknown - but adding the last bit , it now makes sense.

User avatar
Kreuvf
Global Moderator
Global Moderator
Posts: 244
Joined: 22 Sep 2006, 20:56
Contact:

Re: Win98 compatibility

Post by Kreuvf » 07 Jan 2007, 12:26

*callsdevu* That enough?
Contact only via [url=https://warzone2100.de/impressum.php]e-mail[/url]. GPG encryption supported ([url=https://gpg.kreuvf.de/kreuvf2015.asc]my key[/url]).

User avatar
DevUrandom
Regular
Regular
Posts: 1690
Joined: 31 Jul 2006, 23:14

Re: Win98 compatibility

Post by DevUrandom » 07 Jan 2007, 14:01

:)
Ok then. When I have time, I'll create a snapshot of the 2.0 branch with the other, Win98 compatible, folder thingy.

User avatar
lav_coyote25
Professional
Professional
Posts: 3434
Joined: 08 Aug 2006, 23:18

Re: Win98 compatibility

Post by lav_coyote25 » 07 Jan 2007, 19:57

Kreuvf wrote: *callsdevu* That enough?

yes thankyou. ;D
‎"to prepare for disaster is to invite it, to not prepare for disaster is a fools choice" -me (kim-lav_coyote25-metcalfe) - it used to be attributed to unknown - but adding the last bit , it now makes sense.

Mr. Pig
Rookie
Rookie
Posts: 24
Joined: 11 Dec 2006, 06:02

Re: Win98 compatibility

Post by Mr. Pig » 09 Jan 2007, 01:21

DevUrandom wrote: The call would then be

Code: Select all

SHGetSpecialFolderPathA( NULL, tmpstr, CSIDL_PERSONAL, TRUE )
instead of

Code: Select all

SHGetFolderPathA( NULL, CSIDL_PERSONAL|CSIDL_FLAG_CREATE, NULL, SHGFP_TYPE_CURRENT, tmpstr )
?
Can't you just use a #define for the Windows Version number so that it executes the decent function for XP systems and the "bad code" for 98. That way 98 is unsupported but launches? Or are the two functions very different and effect more than just a few lines of code where #defines are not worth it. (I am assuming this is C/C++)

User avatar
DevUrandom
Regular
Regular
Posts: 1690
Joined: 31 Jul 2006, 23:14

Re: Win98 compatibility

Post by DevUrandom » 09 Jan 2007, 18:44

Actually it is only one line of code.
But on WinXP the folder can be a "virtual" one, which means that the user can choose another folder to be his My Documents folder. On Win98 it is a specific path. At least that's how I understood it in the MSDN...
MS provides some hooks to find out the shell32 version at runtime. I'll use that to check which function to use. (But currently have no time. But it is on the roadmap for 2.0.6.)

User avatar
Kreuvf
Global Moderator
Global Moderator
Posts: 244
Joined: 22 Sep 2006, 20:56
Contact:

Re: Win98 compatibility

Post by Kreuvf » 09 Jan 2007, 21:49

DevUrandom wrote: :)
Ok then. When I have time, I'll create a snapshot of the 2.0 branch with the other, Win98 compatible, folder thingy.
Just for clarification: How much disk space is neccessary in order to do win98-compatibility-beta-testing?
Contact only via [url=https://warzone2100.de/impressum.php]e-mail[/url]. GPG encryption supported ([url=https://gpg.kreuvf.de/kreuvf2015.asc]my key[/url]).

User avatar
DevUrandom
Regular
Regular
Posts: 1690
Joined: 31 Jul 2006, 23:14

Re: Win98 compatibility

Post by DevUrandom » 09 Jan 2007, 23:29

About 2MB... You only need a different exe. (So you can look yourself how big that is. The Win98 fallback code wont add many bytes to it. ;) )

PS: Do you have IE5 installed?

Because the MSDN library says about SHGetFolderPath:
MSDN library wrote: Minimum operating systems
Windows 95 with Internet Explorer 5.0, Windows 98 with Internet Explorer 5.0, Windows 98 Second Edition (SE), Windows NT 4.0 with Internet Explorer 5.0, Windows NT 4.0 with Service Pack 4 (SP4)

MSDN library
So actually even Win95 should be supported, as long as IE5 is installed...
Last edited by DevUrandom on 10 Jan 2007, 02:46, edited 1 time in total.

User avatar
Kreuvf
Global Moderator
Global Moderator
Posts: 244
Joined: 22 Sep 2006, 20:56
Contact:

Re: Win98 compatibility

Post by Kreuvf » 10 Jan 2007, 23:23

MSIE6 installed.
Contact only via [url=https://warzone2100.de/impressum.php]e-mail[/url]. GPG encryption supported ([url=https://gpg.kreuvf.de/kreuvf2015.asc]my key[/url]).

Locked